pvary commented on code in PR #17900:
URL: https://github.com/apache/iceberg/pull/17900#discussion_r4154864253


##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DataConverter.java:
##########
@@ -124,6 +124,8 @@ static DataConverter get(LogicalType sourceType, 
LogicalType targetType, boolean
         return new ArrayConverter((ArrayType) sourceType, (ArrayType) 
targetType, caseSensitive);
       case MAP:
         return new MapConverter((MapType) sourceType, (MapType) targetType, 
caseSensitive);
+      case VARIANT:
+        return object -> object;

Review Comment:
   Could this be moved to the first block of the case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to