Revanth14 commented on PR #2097: URL: https://github.com/apache/iceberg-go/pull/2097#issuecomment-5966755183
> Keying variant entries on a length-prefixed `maphash` of the metadata and value bytes (exactly what `VariantLiteral.Equals` compares) and confirming hits with `Equals` fixes the #2093 panic: the new tests panic on the base commit and pass here, including when merged with current `main`. > > ### Smaller observations > * #2088 has landed, so the primitive-column bind that #2093 asks for can be tested now (inline on `exprs_test.go:1140`; needs a rebase). > * The variant-column subtest accepts any bind error (inline on `exprs_test.go:1139`). > > > _This review was drafted by an AI-assisted tool and > > confirmed by an Apache Iceberg maintainer. The maintainer > > approving this PR has read the findings and signed off. If > > something feels off, please reply on the PR and a maintainer > > will follow up._ > > _More on how Apache Iceberg handles maintainer review:_ > > [CONTRIBUTING.md](https://github.com/apache/iceberg-go/blob/main/CONTRIBUTING.md). Thanks @zeroshade @nssalian! Rebased onto `main` and applied both suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
