rdblue commented on code in PR #18331:
URL: https://github.com/apache/iceberg/pull/18331#discussion_r4149927906
##########
core/src/test/java/org/apache/iceberg/TestMetricsConfig.java:
##########
@@ -288,4 +464,62 @@ public void testLimitingMetricsFieldIds() {
.isEqualTo(MetricsModes.Truncate.withLength(16));
assertThat(wider.columnMode(4)).isEqualTo(MetricsModes.None.get());
}
+
+ @Test
+ public void testMetricsConfigKryoSerialization() throws Exception {
Review Comment:
There were no tests for Java or Kryo serialization in core, but
`SerializableMap` is used. I copied these tests from `TestSparkTableUtil`. The
main difference is that Kryo is configured by the test code rather than by
Spark and can't serialize `Collections.unmodifiableMap`. I solve this by
serializing the serializable map and _not_ its immutable view, which is the
right way to use `SerializableMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
