rdblue commented on code in PR #18331:
URL: https://github.com/apache/iceberg/pull/18331#discussion_r4149909624
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -77,9 +77,9 @@ private MetricsConfig(
Map<String, MetricsMode> columnModes,
MetricsMode defaultMode,
Map<Integer, String> idToName) {
- this.columnModes = SerializableMap.copyOf(columnModes).immutableMap();
+ this.columnModes = SerializableMap.copyOf(columnModes);
this.defaultMode = defaultMode;
- this.idToName = idToName != null ?
SerializableMap.copyOf(idToName).immutableMap() : null;
+ this.idToName = idToName != null ? SerializableMap.copyOf(idToName) : null;
Review Comment:
The immutable view is not needed and breaks Kryo serialization. The
`immutableMap` is used to expose maps to callers, so it isn't needed because
these maps are internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
