rdblue commented on code in PR #18331:
URL: https://github.com/apache/iceberg/pull/18331#discussion_r4149894286
##########
core/src/test/java/org/apache/iceberg/TestMetricsModes.java:
##########
@@ -71,206 +40,10 @@ public void testMetricsModeParsing() {
assertThat(MetricsModes.fromString("FULL")).isEqualTo(Full.get());
}
- @TestTemplate
+ @Test
public void testInvalidTruncationLength() {
assertThatThrownBy(() -> MetricsModes.fromString("truncate(0)"))
.isInstanceOf(IllegalArgumentException.class)
.hasMessage("Truncate length should be positive");
}
-
- @TestTemplate
- public void testInvalidColumnModeValue() {
Review Comment:
These are tests for `MetricsConfig`, so I moved them into
`TestMetricsConfig`.
I also updated the tests so that they use `MetricsTestUtil` rather than
creating a table. The problem with creating a table is that the schema IDs are
reassigned. This change doesn't require temp files and writing to disk, and it
also means that the validations for `metricsFieldIds()` match the IDs used to
create the test schemas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
