nastra commented on code in PR #18308: URL: https://github.com/apache/iceberg/pull/18308#discussion_r4141374718
########## format/spec.md: ########## @@ -840,7 +840,7 @@ For example, stats for a `required` `int` field named `id` with field-id `2` are // null_value_count is only used for optional fields // nan_value_count is only used for float and double - // avg_value_size_in_bytes is only used for variable length types + // total_bytes is only used for variable length types Review Comment: I don't know but it seems wasteful to me to store total_bytes for ints/longs/... and other non-variable-length types. Also the reference implementation currently only emits this field for variable-length types, so maybe we just want to continue to only emit it for those types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
