gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r4080841721
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -167,6 +174,17 @@ private TrackedFileStruct(TrackedFileStruct toCopy,
Set<Integer> statsIds) {
toCopy.equalityIds != null
? Arrays.copyOf(toCopy.equalityIds, toCopy.equalityIds.length)
: null;
+
+ if (toCopy.columnFiles != null) {
+ this.columnFiles =
Lists.newArrayListWithCapacity(toCopy.columnFiles.size());
+ for (ColumnFile columnFile : toCopy.columnFiles) {
+ if (columnFile != null) {
Review Comment:
I wasn't sure how much I should guard against null column file. I was extra
cautious here, maybe too much. Null column file is considered a corrupted data,
probably shouldn't handle here. Went with your suggestion, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
