gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r4080204071


##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -167,7 +167,8 @@ public void readDataFile(FileFormat format) throws 
IOException {
             null, // manifest info
             ByteBuffer.wrap(new byte[] {1, 2, 3}), // key metadata
             ImmutableList.of(50L, 100L),
-            null); // equality field IDs
+            null, // equality field IDs
+            null); // column files

Review Comment:
   V4ManifestReader changes are split into a separate follow-up PR: 
https://github.com/apache/iceberg/pull/17826
   It keeps conflicting, so I'll bring it up-to-date once this is merged.
   
   Note, you mention AVRO path, however V4 manifest files are going to be 
Parquet if I'm not mistaken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to