gaborkaszab commented on code in PR #16285:
URL: https://github.com/apache/iceberg/pull/16285#discussion_r4080752137
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -313,6 +337,7 @@ protected <T> void internalSet(int pos, T value) {
case 13 -> this.keyMetadata = ByteBuffers.toByteArray((ByteBuffer)
value);
case 14 -> this.splitOffsets = ArrayUtil.toLongArray((List<Long>) value);
case 15 -> this.equalityIds = ArrayUtil.toIntArray((List<Integer>)
value);
+ case 16 -> this.columnFiles = (List<ColumnFile>) value;
Review Comment:
I don;t think we need a copy of the column file list. This also was called
out by @RussellSpitzer earlier
[here](https://github.com/apache/iceberg/pull/16285#discussion_r3461260653).
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -313,6 +337,7 @@ protected <T> void internalSet(int pos, T value) {
case 13 -> this.keyMetadata = ByteBuffers.toByteArray((ByteBuffer)
value);
case 14 -> this.splitOffsets = ArrayUtil.toLongArray((List<Long>) value);
case 15 -> this.equalityIds = ArrayUtil.toIntArray((List<Integer>)
value);
+ case 16 -> this.columnFiles = (List<ColumnFile>) value;
Review Comment:
I don't think we need a copy of the column file list. This also was called
out by @RussellSpitzer earlier
[here](https://github.com/apache/iceberg/pull/16285#discussion_r3461260653).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
