badalprasadsingh commented on code in PR #1688:
URL: https://github.com/apache/iceberg-go/pull/1688#discussion_r3732324562
##########
table/update_schema.go:
##########
@@ -746,6 +750,10 @@ func (u *UpdateSchema) unionAddColumn(path []string,
newField iceberg.NestedFiel
}
parentID = parentField.ID
+
+ if u.isDeleted(parentID) {
Review Comment:
Done.
Now, `unionAddColumn` uses `findDeletedAncestor` and names the deleted
ancestor. Covered by `TestUnionByNameRejectsAddUnderDeletedAncestor` in both
orders (delete-then-union and union-then-delete).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
