badalprasadsingh commented on code in PR #1688:
URL: https://github.com/apache/iceberg-go/pull/1688#discussion_r3732321834
##########
table/update_schema.go:
##########
@@ -320,6 +320,10 @@ func (u *UpdateSchema) addColumn(path []string, fieldType
iceberg.Type, doc stri
}
parentID = parentField.ID
+
+ if u.isDeleted(parentID) {
Review Comment:
Done.
Now, `findDeletedAncestor` walks the full ancestor chain and reports the
deleted ancestor's name.
The case: `delete outer`, add `outer.inner.new_leaf` : now errors `cannot
add to a column that will be deleted: outer`. This is now covered by
`TestAddColumnUnderDeletedAncestor` (delete-then-add, all nesting kinds).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
