zakariya-s commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3555081406


##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -47,6 +47,11 @@ use crate::{Error, ErrorKind};
 static MAIN_BRANCH: &str = "main";
 pub(crate) static ONE_MINUTE_MS: i64 = 60_000;
 
+/// Table property for the base location of metadata files.
+const WRITE_METADATA_LOCATION: &str = "write.metadata.path";

Review Comment:
   840b992128d3bbf2dd22502cfdfa68bcc430e04a



##########
crates/iceberg/src/catalog/metadata_location.rs:
##########
@@ -50,7 +53,7 @@ impl MetadataLocation {
     )]
     pub fn new_with_table_location(table_location: impl ToString) -> Self {
         Self {
-            table_location: table_location.to_string(),
+            metadata_dir: format!("{}/metadata", table_location.to_string()),

Review Comment:
   840b992128d3bbf2dd22502cfdfa68bcc430e04a



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to