zakariya-s commented on code in PR #2776:
URL: https://github.com/apache/iceberg-rust/pull/2776#discussion_r3554734723
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -2442,12 +2442,13 @@ mod tests {
"v2"
);
- // metadata version should be bumped
+ // metadata version should be bumped and the new metadata file is
written under the updated
+ // table location's metadata directory
assert!(
updated_table
.metadata_location()
.unwrap()
- .starts_with("s3://bucket/test/location/metadata/00001-")
+
.starts_with("s3://bucket/test/new_location/data/metadata/00001-")
Review Comment:
Yeah I agree, I noticed this was another area we departed from the Java
implementation where it should actually be re-deriving the metadata dir from
the new metadata object, [but we don't currently do
so](https://github.com/apache/iceberg-rust/pull/2776/changes/BASE..46f7b18441ab309d615a67d101b1f0e6e1d8983a#diff-c111bafbec2e978e1dac5db9add612084330c3f5d1565baa24c216a3e47b1e6cR93).
I'm happy to split this into a different PR if that makes sense (and if this
perhaps breaks any existing behaviour unintentionally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
