gaborkaszab commented on code in PR #17133:
URL: https://github.com/apache/iceberg/pull/17133#discussion_r3543833539
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -240,12 +231,9 @@ void copy() {
assertThat(copy.keyMetadata()).isEqualTo(ByteBuffer.wrap(new byte[] {1, 2,
3}));
assertThat(copy.splitOffsets()).containsExactly(100L, 200L);
assertThat(copy.equalityIds()).containsExactly(1, 2, 3);
-
- assertThat(PARTITION_COMPARATOR.compare(copy.partition(),
PARTITION)).isEqualTo(0);
+ assertThat(copy.partition()).isSameAs(PARTITION_COPY);
Review Comment:
For the Partition copy we use `isSameAs` while for the Tracking copy we use
`isEqualTo`. Use `isSameAs` for both?
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileStruct.java:
##########
@@ -280,12 +268,12 @@ void structLikeSize() {
void serializationRoundTrip(RoundTripSerializer<TrackedFileStruct>
serializer) throws Exception {
TrackedFileStruct file =
new TrackedFileStruct(
- TRACKING,
+ null, // TrackingStruct has its own serialization tests
Review Comment:
Technically these serialization test changes are irrelevant for the PR
intent: "Use mocks in TrackedFile tests". Should we rephrase the PR title for
this to fit more naturally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
