anoopj commented on code in PR #17133:
URL: https://github.com/apache/iceberg/pull/17133#discussion_r3540575441
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -75,7 +68,7 @@ public PartitionData copy() {
private Tracking tracking = null;
private long recordCount = -1L;
private long fileSizeInBytes = -1L;
- private PartitionData partitionData = EMPTY_PARTITION_DATA;
+ private PartitionData partitionData = null;
Review Comment:
If we want to maintain the contract that `DataFile` continues to return
empty partition instead of `null`, we can potentially handle it in the adapter.
The open question is whether we want to continue to maintain that contract.
Also, we need to capture the null partition tuple for unpartitioned files
either in the spec or the AMT proposal doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
