stevenzwu commented on code in PR #17133:
URL: https://github.com/apache/iceberg/pull/17133#discussion_r3541179813
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -75,7 +68,7 @@ public PartitionData copy() {
private Tracking tracking = null;
private long recordCount = -1L;
private long fileSizeInBytes = -1L;
- private PartitionData partitionData = EMPTY_PARTITION_DATA;
+ private PartitionData partitionData = null;
Review Comment:
It is easy to maintain the contract of `DataFile` returns an empty partition
instead of `null`. And there isn't much gain for breaking the contract. It is
probably better to maintain the same behavior for compatibility.
I thought Amogh is going to update the spec PR that the partition tuple
field is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
