huan233usc commented on code in PR #2692:
URL: https://github.com/apache/iceberg-rust/pull/2692#discussion_r3531129496
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -347,6 +348,10 @@ struct RestContext {
///
/// It's could be different from the user config.
config: RestCatalogConfig,
+ /// The negotiated set of endpoints used for capability negotiation: the
+ /// server's advertised list, or the default base set when its
+ /// `GET /v1/config` response omits `endpoints` or sends an empty list.
+ endpoints: HashSet<Endpoint>,
Review Comment:
Good catch — that comment was misleading. config here is actually the user
config merged with the server's config overrides (not raw server state), so
it's not quite the right home for the negotiated endpoints. I clarified both
field comments to make the distinction clear. Happy to move it if you'd still
prefer, though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
