amogh-jahagirdar commented on code in PR #2692:
URL: https://github.com/apache/iceberg-rust/pull/2692#discussion_r3530446406
##########
crates/catalog/rest/src/types.rs:
##########
@@ -25,10 +25,18 @@ use iceberg::{
};
use serde_derive::{Deserialize, Serialize};
+use crate::endpoint::Endpoint;
+
#[derive(Clone, Debug, Serialize, Deserialize)]
pub(super) struct CatalogConfig {
pub(super) overrides: HashMap<String, String>,
pub(super) defaults: HashMap<String, String>,
+ /// Routes the server advertises support for, for capability negotiation
+ /// (the `endpoints` field of `GET /v1/config`). `None` when the field is
+ /// absent; `Some` (possibly empty) when the server sends it. Resolution
+ /// treats an absent field and an empty list alike — both fall back to the
+ /// default base set.
Review Comment:
I'd remove this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
