kevinjqliu commented on code in PR #2715:
URL: https://github.com/apache/iceberg-rust/pull/2715#discussion_r3523782144
##########
.github/workflows/release_python.yml:
##########
@@ -18,12 +18,14 @@
name: Publish Python 🐍 distribution 📦 to PyPI
on:
- workflow_call:
- inputs:
- release_tag:
- description: 'Release tag (e.g., v0.4.0 or v0.4.0-rc.1)'
- required: true
- type: string
+ # Given PyPI doesn't support workflow reuse,
+ # this workflow independently releases PyPI artifacts rather than being
called by the crates release workflow.
+ push:
+ tags:
+ # Trigger this workflow when tag follows the versioning format:
v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate>
+ # Example valid tags: v0.4.0, v0.4.0-rc.1
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
Review Comment:
```suggestion
```
versioning logic is checked in the `validate-release-tag` step
this workflow will be manually trigger, lets make sure we have it documented
in the "how to release" steps
##########
.github/workflows/release_python.yml:
##########
@@ -225,9 +227,12 @@ jobs:
pattern: wheels-*
merge-multiple: true
path: bindings/python/dist
+
+ # Note: PyPI publish must always be in the top-level workflow
+ # Workflow reuse is not supported by PyPI:
https://github.com/pypi/warehouse/issues/11096
- name: Publish to PyPI
uses:
pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e # v1.13.0
with:
- skip-existing: true
+ skip-existing: false
Review Comment:
```suggestion
skip-existing: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
