blackmwk commented on code in PR #2715: URL: https://github.com/apache/iceberg-rust/pull/2715#discussion_r3518223943
########## .github/workflows/release_python.yml: ########## @@ -18,12 +18,14 @@ name: Publish Python 🐍 distribution 📦 to PyPI on: - workflow_call: - inputs: - release_tag: - description: 'Release tag (e.g., v0.4.0 or v0.4.0-rc.1)' - required: true - type: string + # Given PyPI doesn't support workflow reuse, + # this workflow independently releases PyPI artifacts rather than being called by the crates release workflow. + push: + tags: + # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate> + # Example valid tags: v0.4.0, v0.4.0-rc.1 + - "v[0-9]+.[0-9]+.[0-9]+" + - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+" Review Comment: Do we even publish for a rc tag? Also I'm not sure if the release pyiceberg_core build should depend publish crates or local crates? I also prefer to keep the manual workflow trigger for now so that if the change doesn't work, we could still publish it without a change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
