kevinjqliu commented on code in PR #2715: URL: https://github.com/apache/iceberg-rust/pull/2715#discussion_r3523780446
########## .github/workflows/release_python.yml: ########## @@ -18,12 +18,14 @@ name: Publish Python 🐍 distribution 📦 to PyPI on: - workflow_call: - inputs: - release_tag: - description: 'Release tag (e.g., v0.4.0 or v0.4.0-rc.1)' - required: true - type: string + # Given PyPI doesn't support workflow reuse, + # this workflow independently releases PyPI artifacts rather than being called by the crates release workflow. + push: + tags: + # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate> + # Example valid tags: v0.4.0, v0.4.0-rc.1 + - "v[0-9]+.[0-9]+.[0-9]+" + - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+" Review Comment: lets keep the manual trigger, @CTTY prefers the same in the comment above. we do publish prerelease version for pyiceberg-core, its a good smoke test https://pypi.org/project/pyiceberg-core/0.10.0rc2/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
