manuzhang commented on code in PR #16945:
URL: https://github.com/apache/iceberg/pull/16945#discussion_r3471437867


##########
.github/workflows/delta-conversion-ci.yml:
##########
@@ -78,7 +78,7 @@ jobs:
     strategy:
       max-parallel: 15
       matrix:
-        jvm: [17, 21]
+        jvm: ${{ fromJson((github.event_name == 'pull_request' && 
contains(github.event.pull_request.labels.*.name, 'full-ci') == false) && 
'[17]' || '[17,21]') }}

Review Comment:
   I'm not sure whether it's easy to read and maintain with this format. Is 
there a way to separate configs from logic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to