Baunsgaard commented on PR #16945: URL: https://github.com/apache/iceberg/pull/16945#issuecomment-4790917401
> > I like this code much better already! The one thing missing in my opinion is to still run at least one JVM 21 version. This would still nearly cut the CI in half, but still give some indication on the PR if Java 21 is broken! > > Good point! I actually thought about doing exactly that, but I still worry it might be too expensive for PR runs. Usually, if a build passes on one JDK, it passes on the others—I can't recall a time we had a version-specific failure on a PR. Since we have the safeguard on main, I'd vote to keep it lean for now. > > Let's see what the rest of the group thinks. If we have the luxury of extra resources and want that extra peace of mind, we can always turn it on later! I would still suggest to have that one Java21 run. The difference in CI usage is minimal (12.5%), and it is better to have some of the coverage than none. I have seen now many times that something breaks in other versions if not tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
