kevinjqliu commented on code in PR #16945:
URL: https://github.com/apache/iceberg/pull/16945#discussion_r3482847066
##########
.github/workflows/delta-conversion-ci.yml:
##########
@@ -78,7 +78,7 @@ jobs:
strategy:
max-parallel: 15
matrix:
- jvm: [17, 21]
+ jvm: ${{ fromJson((github.event_name == 'pull_request' &&
contains(github.event.pull_request.labels.*.name, 'full-ci') == false) &&
'[17]' || '[17,21]') }}
Review Comment:
```suggestion
# PRs run Java 17 only; all other events run Java 17 and 21.
jvm: ${{ fromJSON(case(github.event_name == 'pull_request', '[17]',
'[17,21]')) }}
```
could we forgo the `full-ci` feature for now?
##########
.github/workflows/flink-ci.yml:
##########
@@ -98,7 +97,13 @@ jobs:
# Read-only: java-ci's build-checks (17) is the global canonical
writer.
cache-read-only: true
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- - run: ./gradlew -DsparkVersions= -DkafkaVersions= -DflinkVersions=${{
matrix.flink }} :iceberg-flink:iceberg-flink-${{ matrix.flink }}:check
:iceberg-flink:iceberg-flink-runtime-${{ matrix.flink }}:check -Pquick=true -x
javadoc -DtestParallelism=auto
+ - env:
+ FLINK_VERSION: ${{ matrix.flink }}
Review Comment:
this seems unrelated to this pr, i saw theres another flink version related
pr
##########
.github/workflows/spark-ci.yml:
##########
@@ -110,14 +110,21 @@ jobs:
cache-read-only: true
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run tests
+ env:
+ SPARK_VERSION: ${{ matrix.spark }}
+ SCALA_VERSION: ${{ matrix.scala }}
+ TEST_GROUP: ${{ matrix.tests }}
run: |
- if [[ "${{ matrix.tests }}" == "core" ]]; then
- projects=":iceberg-spark:iceberg-spark-${{ matrix.spark }}_${{
matrix.scala }}:check"
+ if [[ "${TEST_GROUP}" == "core" ]]; then
Review Comment:
mind removing unrelated changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
