wombatu-kun commented on code in PR #16852:
URL: https://github.com/apache/iceberg/pull/16852#discussion_r3433018269
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java:
##########
@@ -1349,6 +1349,95 @@ public void
testArrayWithElementValueTypedValueConflict() {
.hasMessageContaining("Invalid variant, conflicting value and
typed_value");
}
+ @Test
+ public void testMetadataCachingWithIdenticalRows() throws IOException {
Review Comment:
Confirmed addressed by commit 2: the `isSameAs` / `isNotSameAs` assertions
now fail if the cache is reverted, since `read()` would otherwise return a
fresh instance per row, and both the length and byte-content invalidation paths
are covered. I can't resolve the thread myself, so feel free to close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
