wombatu-kun commented on code in PR #16852:
URL: https://github.com/apache/iceberg/pull/16852#discussion_r3432662972
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestVariantReaders.java:
##########
@@ -1349,6 +1349,95 @@ public void
testArrayWithElementValueTypedValueConflict() {
.hasMessageContaining("Invalid variant, conflicting value and
typed_value");
}
+ @Test
+ public void testMetadataCachingWithIdenticalRows() throws IOException {
Review Comment:
These three tests pass unchanged if the caching in
`ParquetVariantReaders.read` is reverted, since they assert only decoded values
- they exercise the cache branches but never prove a hit actually skipped a
re-parse. Consider adding a parse/hit counter (e.g. a `@VisibleForTesting`
field on `VariantMetadataReader`) and asserting it here, so a future change
that silently breaks or drops the cache is caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
