singhpk234 commented on code in PR #16768:
URL: https://github.com/apache/iceberg/pull/16768#discussion_r3398122573
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -107,7 +107,18 @@ public CloseableIterator<FileScanTask> iterator() {
}
@Override
- public void close() throws IOException {}
+ public void close() throws IOException {
+ if (shutdown.compareAndSet(false, true)) {
+ LOG.info(
+ "ScanTaskIterable is closing. Clearing {} queued tasks, {} plan
tasks, and {} initial file scan tasks.",
+ taskQueue.size(),
+ planTasks.size(),
+ initialFileScanTasks.size());
+ taskQueue.clear();
+ planTasks.clear();
+ initialFileScanTasks.clear();
+ }
+ }
Review Comment:
why not call ScanTasksIterator.close() instead ?
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -107,7 +107,18 @@ public CloseableIterator<FileScanTask> iterator() {
}
@Override
- public void close() throws IOException {}
+ public void close() throws IOException {
+ if (shutdown.compareAndSet(false, true)) {
+ LOG.info(
+ "ScanTaskIterable is closing. Clearing {} queued tasks, {} plan
tasks, and {} initial file scan tasks.",
+ taskQueue.size(),
+ planTasks.size(),
+ initialFileScanTasks.size());
+ taskQueue.clear();
+ planTasks.clear();
+ initialFileScanTasks.clear();
+ }
Review Comment:
we should make a helper function and reuse it in both the places where close
is called ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
