sejal-gupta-ksolves commented on PR #16768: URL: https://github.com/apache/iceberg/pull/16768#issuecomment-4688864734
@chenwyi2 Yes, `close()` will be invoked automatically by StarRocks FE without requiring any downstream code changes. During query planning and range deployment, StarRocks processes the file splits via Iceberg's `CloseableIterable` scan stream. When a query is cancelled or times out, StarRocks' coordinator explicitly cascades a `.close()` signal down to this execution stream wrapper to free resources. Because this patch unifies the cleanup paths by having the iterator directly delegate to `ScanTaskIterable.this.close()`, any termination signal triggered by StarRocks will instantly flip the shutdown barrier, empty the planning queues, and gracefully exit the blocked background worker threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
