sejal-gupta-ksolves commented on code in PR #16768:
URL: https://github.com/apache/iceberg/pull/16768#discussion_r3412800367
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -107,7 +107,18 @@ public CloseableIterator<FileScanTask> iterator() {
}
@Override
- public void close() throws IOException {}
Review Comment:
Thanks for pointing me to the `ParallelIterable` pattern! I have refactored
`ScanTaskIterable` to extend `CloseableGroup` and explicitly register the
instantiated iterator via `addCloseable(iter)` inside the `iterator()` factory
method.
I also updated `ScanTasksIterator.close()` to toggle the `shutdown` flag to
ensure that the cascaded close signals cleanly terminate active background
planning workers and prevent test timeouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
