Guosmilesmile commented on code in PR #16724: URL: https://github.com/apache/iceberg/pull/16724#discussion_r3379988619
########## data/src/test/java/org/apache/iceberg/data/FileFormatTestSupport.java: ########## @@ -58,4 +59,6 @@ void writeRecordsWithoutFieldIds(OutputFile outputFile, Schema schema, List<Reco String metadataValue(InputFile inputFile, String key) throws IOException; String splitSizeProperty(); + + void assertEncryptedFileUnreadable(ThrowingCallable readEncryptedFile); Review Comment: It seems different formats throw different exceptions with different messages — Parquet throws a special ParquetCryptoRuntimeException, while the others throw a plain RuntimeException. That's why I had to split them apart. Also, I want to verify that the write succeeded by reading the data back without the encryption info, which is why this is needed too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
