pvary commented on code in PR #16724: URL: https://github.com/apache/iceberg/pull/16724#discussion_r3379839289
########## data/src/test/java/org/apache/iceberg/data/FileFormatTestSupport.java: ########## @@ -58,4 +59,6 @@ void writeRecordsWithoutFieldIds(OutputFile outputFile, Schema schema, List<Reco String metadataValue(InputFile inputFile, String key) throws IOException; String splitSizeProperty(); + + void assertEncryptedFileUnreadable(ThrowingCallable readEncryptedFile); Review Comment: Why do we need file specific assertions? I would probably just accept that any exception is a good exception in these tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
