Guosmilesmile commented on code in PR #16724:
URL: https://github.com/apache/iceberg/pull/16724#discussion_r3381216810
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -1706,6 +1715,98 @@ void testDataWriterMetaMap(FileFormat fileFormat) throws
IOException {
});
}
+ @ParameterizedTest
+ @FieldSource("FILE_FORMATS")
+ void testDataWriterEncryption(FileFormat fileFormat) throws IOException {
Review Comment:
The difference between these two methods lies in the purpose of
testDataWriterEncryption: it is used to test whether
keyMetadata(encryptedOutputFile.keyMetadata()) is actually effective. On the
other hand, testDataWriterWithFileEncryptionKeyAndWithAADPrefix is used to test
whether the options withFileEncryptionKey and withAADPrefix are effective.
Since FileFormat is an input parameter, both methods will test all possible
file formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
