blackmwk commented on code in PR #2589:
URL: https://github.com/apache/iceberg-rust/pull/2589#discussion_r3378731252
##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -142,8 +141,52 @@ impl SnapshotSummaryCollector {
}
/// Builds final map of summaries
- pub fn build(&self) -> HashMap<String, String> {
+ pub fn build(&self, prev_summary: Option<&Summary>) -> HashMap<String,
String> {
Review Comment:
I don't think this breaking change is an elegant design. The goal of this pr
is to fix a bug when updating snapshot summary, but now it changed the
semantics of a pub api. Though I agree that existing design is not rust
idiomatic, this change is doesn't not solve it elegantly. My suggestion is to
limit the pr to bug fix only , and we could do rerefactoring in follow up pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
