dannycjones commented on code in PR #2589:
URL: https://github.com/apache/iceberg-rust/pull/2589#discussion_r3362309596
##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -483,27 +483,37 @@ fn update_totals(
added_property: &str,
removed_property: &str,
) {
- let previous_total = previous_summary.map_or(0, |previous_summary| {
- previous_summary
- .additional_properties
- .get(total_property)
- .map_or(0, |value| value.parse::<u64>().unwrap())
- });
+ let previous_total = match previous_summary {
+ Some(previous_summary) => {
+ match previous_summary.additional_properties.get(total_property) {
+ Some(value) => match value.parse::<u64>() {
+ Ok(v) => v,
+ Err(e) => {
+ tracing::warn!(
+ "Failed to parse previous summary property
'{total_property}' value '{value}': {e}. \
+ Skipping total computation.",
+ );
+ return;
+ }
+ },
+ None => return,
+ }
+ }
+ None => 0,
+ };
let mut new_total = previous_total;
- if let Some(value) = summary
- .additional_properties
- .get(added_property)
- .map(|value| value.parse::<u64>().unwrap())
- {
- new_total += value;
+ if let Some(value) = summary.additional_properties.get(added_property) {
+ match value.parse::<u64>() {
+ Ok(v) => new_total += v,
+ Err(_) => return,
Review Comment:
Actually, I think it would be worth rethinking now.
My thoughts are that this logic should live in the snapshot collector and
not as an afterthought. I'd propose taking the previous snapshot into the
`build()` method on the collector, such that the summaries are final once built.
https://github.com/apache/iceberg-rust/blob/97711b95a90826c39cc32b378c0e91d5c978ffe9/crates/iceberg/src/transaction/snapshot.rs#L405-L407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
