dannycjones commented on PR #2589: URL: https://github.com/apache/iceberg-rust/pull/2589#issuecomment-4669451498
> LGTM! > > This decription is kinda confusing though, is it stale? > > > This change also removes the table truncation metrics path which is currently unused / dead code. I do not believe that it was implemented correctly for partial overwrites, and so I've removed it for now. I think we'd be better suited letting the snapshot collector handle this behavior (which is yet to be implemented). Yeah, that was stale - sorry. I've updated the PR description but looks like it is already in the commit message. I'll make sure to review the PR description after every push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
