wgtmac commented on code in PR #648:
URL: https://github.com/apache/iceberg-cpp/pull/648#discussion_r3271060784
##########
src/iceberg/test/expire_snapshots_test.cc:
##########
@@ -350,6 +351,11 @@ TEST_F(ExpireSnapshotsCleanupTest,
IgnoresExpiredDeleteManifestReadFailures) {
std::vector<std::string> deleted_files;
ICEBERG_UNWRAP_OR_FAIL(auto update, table_->NewExpireSnapshots());
+ // Force ReachableFileCleanup: the empty current manifest list makes this an
+ // unreachable-orphan scenario, which Incremental cannot detect
(added-in-ancestor
+ // files are preserved unless an explicit DELETED entry exists). Specifying
the
+ // snapshot id forces the dispatch to Reachable.
+ update->ExpireSnapshotId(kExpiredSnapshotId);
Review Comment:
This now forces the reachable path, but the assertion still omits
`expired_delete_file_path`. Please make reachable cleanup delete orphaned
delete files under `kAll` and assert it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
