wgtmac commented on code in PR #648:
URL: https://github.com/apache/iceberg-cpp/pull/648#discussion_r3264528272
##########
src/iceberg/test/expire_snapshots_test.cc:
##########
@@ -573,4 +580,75 @@ TEST_F(ExpireSnapshotsCleanupTest,
KeepsReusedPartitionStats) {
EXPECT_THAT(deleted_files,
testing::Not(testing::Contains(reused_statistics_path)));
}
+// Linear-ancestry, no specified ID: dispatch must pick IncrementalFileCleanup.
Review Comment:
This comment is doing too much and calls out Java again. Please trim it to
the setup expectation: no explicit ID should take the incremental path and
preserve the added data file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
