wgtmac commented on code in PR #648:
URL: https://github.com/apache/iceberg-cpp/pull/648#discussion_r3271058375
##########
src/iceberg/update/pending_update.cc:
##########
@@ -47,8 +47,7 @@ Status PendingUpdate::Commit() {
return std::unexpected(commit_result.error());
}
- std::ignore = Finalize(commit_result.value()->metadata().get());
- return {};
+ return Finalize(commit_result.value()->metadata().get());
Review Comment:
This only fixes the table-created path. `Transaction::Commit()` still
ignores `Finalize()`, so the same cleanup error is swallowed for staged
updates. Please propagate it there too and cover the transaction path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
