pvary commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3266427638
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -459,7 +517,7 @@ void
testPositionDeleteWriterEngineWriteGenericRead(FileFormat fileFormat) throw
@ParameterizedTest
@FieldSource("FILE_FORMATS")
void testReaderBuilderProjection(FileFormat fileFormat) throws IOException {
- DataGenerator dataGenerator = new DataGenerators.DefaultSchema();
+ DataGenerator dataGenerator = new DataGenerators.Primitives();
Review Comment:
This doesn't seem correct. Probably we don't want to use the full Primitives
schema everywhere.
I would suggest to keep a DefaultSchema for most of the tests. Maybe don't
add it to the `ALL` list, but keep it and use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
