pvary commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3266411630
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -130,6 +136,50 @@ protected boolean supportsBatchReads() {
@TempDir private File tableDir;
+ protected boolean supportsTime() {
+ return true;
+ }
+
+ protected boolean supportsUUID() {
+ return true;
+ }
Review Comment:
Only introduce strictly required ones.
Generic format model test should support all (in another PR we might want to
create a
```
public class TestGenericFormatModel extends BaseFormatModelTests<Record> {
[..]
}
```
Individual engines could say that they are not supporting some of the types
(Spark - Time, Flink - Time, Variant)
Maybe the best solution would be to have all of them in the Primitives
schema, and the engine could filter out the ones not supported one by a single
override method? WDYT?
```
protected Schema filterUnsupported(Schema schema) {
[..]
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
