rambleraptor commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3262440773
##########
data/src/test/java/org/apache/iceberg/data/DataGenerators.java:
##########
@@ -29,10 +29,91 @@
*/
class DataGenerators {
- static final DataGenerator[] ALL = new DataGenerator[] {new
StructOfPrimitive()};
+ static final DataGenerator[] ALL =
+ new DataGenerator[] {
+ new Primitives(),
+ new UUID(),
+ new Fixed(),
+ new Binary(),
+ new StructOfPrimitive(),
+ new ListOfPrimitive(),
+ new MapOfPrimitive(),
+ new TimestampNano()
+ };
private DataGenerators() {}
+ static class Primitives implements DataGenerator {
Review Comment:
Take a look at the new version and let me know if that matches what you
think. There's been some movement since this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
