pvary commented on code in PR #15996:
URL: https://github.com/apache/iceberg/pull/15996#discussion_r3248867318
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DVMergeCommand.java:
##########
@@ -16,20 +16,33 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.iceberg.orc;
+package org.apache.iceberg.flink.maintenance.operator;
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.iceberg.io.InputFile;
-import org.apache.iceberg.io.OutputFile;
+import java.io.Serializable;
+import java.util.List;
+import org.apache.flink.annotation.Internal;
+import org.apache.iceberg.DeleteFile;
+import org.apache.iceberg.StructLike;
-public class OrcWritingTestUtils {
- private OrcWritingTestUtils() {}
+/**
+ * Command from the {@link EqualityConvertDVResolver} to the {@link
EqualityConvertDVMerger}.
+ * Contains the positions to delete for a single data file, along with
partition info and any
+ * existing DV metadata needed for merge.
+ */
+@Internal
+public record DVMergeCommand(
+ String dataFilePath,
+ List<Long> positions,
+ int specId,
+ StructLike partition,
+ DeleteFile existingDV)
+ implements Serializable {
- public static FileSystem outputFileSystem(OutputFile file) {
- return new FileIOFSUtil.OutputFileSystem(file);
+ public static DVMergeCommand abort() {
+ return new DVMergeCommand(null, null, 0, null, null);
Review Comment:
Would it worth not to create a new instance every time, just use a static
one?
Same for all of the other recrod/data objects with `abort`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
