pvary commented on code in PR #15996: URL: https://github.com/apache/iceberg/pull/15996#discussion_r3248837431
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DVMergeResult.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.io.Serializable; +import java.util.List; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +/** + * Result from the {@link EqualityConvertDVMerger} containing new and rewritten DV files produced by + * a single merger instance. A result with {@link #hasError()} signals that the merger failed; the + * committer must not commit data files in that case. + */ +@Internal +public record DVMergeResult( + List<DeleteFile> dvFiles, List<DeleteFile> rewrittenDvFiles, boolean hasError) + implements Serializable { + + public DVMergeResult(List<DeleteFile> dvFiles, List<DeleteFile> rewrittenDvFiles) { + this(dvFiles, rewrittenDvFiles, false); + } + + /** Returns a sentinel result that tells the committer to abort the current cycle. */ + public static DVMergeResult abort() { + return new DVMergeResult(Lists.newArrayList(), Lists.newArrayList(), true); Review Comment: nit: would it be better like this? ```suggestion return new DVMergeResult(null, null true); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
