Guosmilesmile commented on code in PR #16065:
URL: https://github.com/apache/iceberg/pull/16065#discussion_r3238820273
##########
docs/docs/flink-writes.md:
##########
@@ -550,6 +550,8 @@ The Dynamic Iceberg Flink Sink is configured using the
Builder pattern. Here are
| `setAll(Map<String, String> properties)` | Set multiple
properties at once
|
| `tableCreator(TableCreator creator)` | When DynamicIcebergSink creates new
Iceberg tables, allows overriding how tables are created - setting custom table
properties and location based on the table name. |
| `dropUnusedColumns(boolean enabled)` | When enabled, drops
all columns from the current table schema which are not contained in the input
schema (see the caveats above on dropping columns). |
+| `shuffeSinkSlotSharingGroup(SlotSharingGroup ssg)` | Set the [slot sharing
group](https://nightlies.apache.org/flink/flink-docs-stable/docs/deployment/finegrained_resource/)
for the shuffle sink. |
+| `generatorSlotSharingGroup(SlotSharingGroup ssg)` | Set the [slot sharing
group](https://nightlies.apache.org/flink/flink-docs-stable/docs/deployment/finegrained_resource/)
for the generator (and forward sink chained to it). |
Review Comment:
Here's my immature take - if we go with the SlotSharingGroup class
approach, we'd need to split it into a bunch of extra configs for SQL/config
integration, while a simple string would be much easier to plug into SQL. For
users who need custom slot group resources, they can just define them upfront
in the env, which keeps the config simple. If more users ask for it later, we
can always add slot group resource configs then. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
