sqd commented on code in PR #16065:
URL: https://github.com/apache/iceberg/pull/16065#discussion_r3219957892
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -511,6 +529,9 @@ public DataStreamSink<DynamicRecordInternal> append() {
.uid(prefixIfNotNull(uidPrefix, "-generator"))
.name(operatorName("generator"))
.returns(type);
+ if (generatorSlotSharingGroup != null) {
+ converted.slotSharingGroup(generatorSlotSharingGroup);
+ }
Review Comment:
Replied above.
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -532,6 +553,9 @@ public DataStreamSink<DynamicRecordInternal> append() {
shuffleInput
.sinkTo(sink) // Forward write results are implicitly injected
here
.uid(prefixIfNotNull(uidPrefix, "-sink"));
+ if (shuffeSinkSlotSharingGroup != null) {
+ result.slotSharingGroup(shuffeSinkSlotSharingGroup);
+ }
Review Comment:
Replied above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
