sqd commented on code in PR #16065:
URL: https://github.com/apache/iceberg/pull/16065#discussion_r3219956634
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -447,6 +461,10 @@ private DynamicIcebergSink build(
.setParallelism(converted.getParallelism())
.uid(prefixIfNotNull(uidPrefix, "-forward-writer"));
+ if (generatorSlotSharingGroup != null) {
+ forwardWriteResults.slotSharingGroup(generatorSlotSharingGroup);
+ }
+
Review Comment:
Unfortunately no, that is not equivalent. If unset, Flink tries to inherit
the slot sharing group from the input operators; if set to
DEFAULT_SLOT_SHARING_GROUP, that behavior is bypassed.
https://github.com/apache/flink/blob/release-2.1/flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java#L651-L666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
