huaxingao commented on code in PR #15470:
URL: https://github.com/apache/iceberg/pull/15470#discussion_r3230005348
##########
.palantir/revapi.yml:
##########
@@ -404,6 +404,143 @@ acceptedBreaks:
old: "method org.apache.iceberg.orc.ORC.WriteBuilder
org.apache.iceberg.orc.ORC.WriteBuilder::config(java.lang.String,\
\ java.lang.String)"
justification: "Removing deprecations for 1.2.0"
+ "1.10.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.class.defaultSerializationChanged"
+ old: "class org.apache.iceberg.encryption.EncryptingFileIO"
+ new: "class org.apache.iceberg.encryption.EncryptingFileIO"
+ justification: "New method for Manifest List reading"
+ org.apache.iceberg:iceberg-core:
+ - code: "java.class.noLongerInheritsFromClass"
Review Comment:
Could you keep only the four new entries and revert the
reordering/re-indentation of the existing 1.10.0 block? Manually adding the new
entries into the existing block (keeping the original 4-space indent and
ordering) would make the diff much smaller and easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
