mbutrovich commented on code in PR #15470: URL: https://github.com/apache/iceberg/pull/15470#discussion_r3235938941
########## core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java: ########## @@ -28,6 +28,7 @@ import java.util.Set; import java.util.stream.Collectors; import java.util.stream.StreamSupport; +import org.apache.hadoop.fs.FileAlreadyExistsException; Review Comment: Thanks @kevinjqliu, good catch. The Hadoop import came in with the cross-task dedup fix and shouldn't be there. The fix depends on the approach we settle on for @huaxingao's race comment above: - If we go with per-task UUID staging, the whole `try/catch FileAlreadyExistsException` block goes away and so does the import. - If we keep the deterministic shared staging path with a per-task scratch fallback, I'll switch the catch to `org.apache.iceberg.exceptions.AlreadyExistsException` (what `OutputFile.create()` documents). Will address as part of that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
