gaborkaszab commented on code in PR #16148:
URL: https://github.com/apache/iceberg/pull/16148#discussion_r3168831361
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -3986,6 +3987,112 @@ protected RESTSessionCatalog newSessionCatalog(
return catalog;
}
+ @Test
+ public void testAddSchemaWithExistingIdAndDifferentSchema() {
Review Comment:
I think here the point is that we can't know if the requests are created via
the Table/View API from the Java lib, because there are other projects, other
custom implementations that could leverage the reference IRC implementation for
testing. So the question is how far do we wanna go with input verification on
the reference IRC side. Since this is a reference, demonstration purpose
implementation, I'd lean toward not to seek thoroughness because that'd shift
the focus of the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
