gaborkaszab commented on PR #16148: URL: https://github.com/apache/iceberg/pull/16148#issuecomment-4342917856
Thank you for looking into this, @rambleraptor! Just to understand the context: isn't this the behavior now for all the metadata elements that have an ID, like partition specs, sort orders, schemas, etc.? I believe that the reference IRC implementation is more for demonstration purposes and not for full coverage on all the inputs (including input validation). I also see that we don't even validate the requirements within UpdateTableRequest. This makes me think that this is on purpose. If we added schema validations now, it's hard to argue why stop here and not to add validation for everything else too, that would push the focus on a more thorough implementation from demonstration purposes. I wonder what others think here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
